Fix clamping for nested elements by ensuring that some core function …

…is always called with an Array, not a NodeList
makandra · Oct 23, 2019 · ec85d09 · ec85d09
1 parent a179a5a
commit ec85d09
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 7 deletions.
diff --git a/dist/superclamp.js b/dist/superclamp.js
@@ -1,6 +1,6 @@
 
 /*!
- * Superclamp 0.2.1
+ * Superclamp 0.2.2
  * https://github.com/makandra/superclamp
  */
 
@@ -413,7 +413,7 @@
   };
 
   getContents = function(node) {
-    return node.childNodes;
+    return Array.prototype.slice.call(node.childNodes);
   };
 
   hideAll = function(nodes) {

diff --git a/dist/superclamp.min.js b/dist/superclamp.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "superclamp",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "Cross-browser ellipsis for multi-line texts, optimized for performance. No dependencies.",
   "main": "dist/superclamp.js",
   "files": [

diff --git a/src/superclamp.coffee b/src/superclamp.coffee
@@ -1,5 +1,5 @@
 ###!
- * Superclamp 0.2.1
+ * Superclamp 0.2.2
  * https://github.com/makandra/superclamp
 ###
 
@@ -335,7 +335,7 @@ initializeTextNode = (textNode) ->
   return
 
 getContents = (node) ->
-  node.childNodes
+  Array.prototype.slice.call(node.childNodes)
 
 hideAll = (nodes) ->
   debug 'hideAll', nodes

diff --git a/test/index.html b/test/index.html
@@ -95,6 +95,16 @@ <h2>Container including paragraphs (KNOWN ISSUE: ellipsis will be outside of par
   Etiam in nisl sed lorem venenatis cursus. Morbi ultrices interdum ipsum, non viverra tellus dictum non. Fusce vitae lacinia purus. Vestibulum eu libero eget odio venenatis malesuada. Nulla ligula purus, facilisis vel venenatis vel, ornare euismod lorem. Sed lacinia fermentum sem, quis posuere urna aliquam non. Fusce et sagittis mauris, non lacinia metus.
   </p>
 </div>
+<h2>Container including nested elements</h2>
+<div class="clamp-me">
+  <div class="nested-container">
+    <p>
+    Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam gravida sem quam, a pulvinar diam mattis at. Fusce sit amet tortor nibh. Nunc vel augue scelerisque, blandit nunc in, ornare diam. Phasellus egestas venenatis ligula, a imperdiet libero pretium non. Etiam id urna ut eros rutrum varius. Donec sit amet ligula blandit, tincidunt massa id, rhoncus eros. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus.
+    </p><p>
+    Quisque hendrerit turpis sit amet enim auctor, sed posuere libero hendrerit. In ante justo, dignissim eget sapien eu, interdum pulvinar erat. Vestibulum non fermentum mi, ut convallis libero.
+    </p>
+  </div>
+</div>
 <!--
 <h2>Many more elements to be clamped, to reveal performance issues</h2>
 <div class="clamp-me">