[Discover] Always request unmapped fields in a single doc view and a …

…context view (elastic#91825) * [Discover] Always request unmapped fields in a single doc view * Updating unit test * Request unmapped fields in context view
majagrubic · Feb 18, 2021 · 38386b0 · 38386b0
1 parent 758bc96
commit 38386b0
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/src/plugins/discover/public/application/angular/context/api/anchor.js b/src/plugins/discover/public/application/angular/context/api/anchor.js
@@ -32,7 +32,7 @@ export function fetchAnchorProvider(indexPatterns, searchSource, useNewFieldsApi
       .setField('sort', sort);
     if (useNewFieldsApi) {
       searchSource.removeField('fieldsFromSource');
-      searchSource.setField('fields', ['*']);
+      searchSource.setField('fields', [{ field: '*', include_unmapped: 'true' }]);
     }
     const response = await searchSource.fetch();
 

diff --git a/src/plugins/discover/public/application/angular/context/api/anchor.test.js b/src/plugins/discover/public/application/angular/context/api/anchor.test.js
@@ -154,7 +154,7 @@ describe('context app', function () {
         const removeFieldsSpy = searchSourceStub.removeField.withArgs('fieldsFromSource');
         expect(setFieldsSpy.calledOnce).toBe(true);
         expect(removeFieldsSpy.calledOnce).toBe(true);
-        expect(setFieldsSpy.firstCall.args[1]).toEqual(['*']);
+        expect(setFieldsSpy.firstCall.args[1]).toEqual([{ field: '*', include_unmapped: 'true' }]);
       });
     });
   });

diff --git a/src/plugins/discover/public/application/angular/context/api/context.ts b/src/plugins/discover/public/application/angular/context/api/context.ts
@@ -114,7 +114,7 @@ function fetchContextProvider(indexPatterns: IndexPatternsContract, useNewFields
     const searchSource = await data.search.searchSource.create();
     if (useNewFieldsApi) {
       searchSource.removeField('fieldsFromSource');
-      searchSource.setField('fields', ['*']);
+      searchSource.setField('fields', [{ field: '*', include_unmapped: 'true' }]);
     }
     return searchSource
       .setParent(undefined)

diff --git a/src/plugins/discover/public/application/components/doc/use_es_doc_search.test.tsx b/src/plugins/discover/public/application/components/doc/use_es_doc_search.test.tsx
@@ -67,7 +67,10 @@ describe('Test of <Doc /> helper / hook', () => {
         "_source": false,
         "docvalue_fields": Array [],
         "fields": Array [
-          "*",
+          Object {
+            "field": "*",
+            "include_unmapped": "true",
+          },
         ],
         "query": Object {
           "ids": Object {

diff --git a/src/plugins/discover/public/application/components/doc/use_es_doc_search.ts b/src/plugins/discover/public/application/components/doc/use_es_doc_search.ts
@@ -39,7 +39,7 @@ export function buildSearchBody(
     },
     stored_fields: computedFields.storedFields,
     _source: !useNewFieldsApi,
-    fields: useNewFieldsApi ? ['*'] : undefined,
+    fields: useNewFieldsApi ? [{ field: '*', include_unmapped: 'true' }] : undefined,
     script_fields: computedFields.scriptFields,
     docvalue_fields: computedFields.docvalueFields,
   };