Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maistra-2.3] OSSM-2109 Fix flaky IOR unit test #648

Merged
merged 1 commit into from
Oct 11, 2022
Merged

[maistra-2.3] OSSM-2109 Fix flaky IOR unit test #648

merged 1 commit into from
Oct 11, 2022

Commits on Oct 11, 2022

  1. OSSM-2109 Fix flaky IOR unit test 

    The sleep in ensureNamespaceExists was hardcoded to 100ms, regardless of r.handleEventTimeout. This timeout during unit tests is only 1ms, so the 100ms sleep caused the for loop to only run once.

Here we change the duration of the sleep to be 1/100 of r.handleEventTimeout. This change preserves the production sleep time of 100ms, but reduces the sleep time in unit tests to 10μs. This makes ensureNamespaceExists() run the for loop multiple times before giving up, fixing the test's flakiness.
    @luksa
    luksa authored and maistra-bot committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    71d2104 View commit details
    Browse the repository at this point in the history