-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maistra-2.6] Rebase commits between 2.5.0 and 2.5.2 #1016
[maistra-2.6] Rebase commits between 2.5.0 and 2.5.2 #1016
Conversation
bc9f62b
to
8f296b6
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSSM-5556 was reverted: #964
@jewertow as you suggest in the reverted commit, we don't want to include the fix in the Z-stream. This is a Y-stream. Should we include it? |
/retest |
No, we do not want that change at all. |
8f296b6
to
a32ca35
Compare
TagWatcher requires cluster-scoped permissions for MutatingWebhooks, so we can't support it in multi-tenant mode. On the other hand, it can't be used in cluster-wide mode as well, because TagWatcher watches MutatingWebhooks and relies on istio.io/rev label, which is not unique across control planes in OSSM. Additionally, TagWatcher causes skipping Gateways which do not have istio.io/rev label while the control plane is a revision different than "default". Co-authored-by: Jacek Ewertowski <[email protected]> Signed-off-by: Yann Liu <[email protected]>
I have dropped a commit to resolve the conflict with #1002. The commit was picked from istio/istio#48056, which includes some changes on |
* OSSM-6079: Pass --resync flag to federation registry Signed-off-by: Jacek Ewertowski <[email protected]> * Remove comments for defaultRetry Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]>
…eeds 60KB (#49363) (maistra#950) * samples: do not return request body as a header to avoid 431 * Typo fixes --------- Signed-off-by: Jacek Ewertowski <[email protected]> Co-authored-by: Jacek Ewertowski <[email protected]>
…d GatewayAPI is disabled (maistra#977)
…ra#978) Co-authored-by: Marko Lukša <[email protected]> Signed-off-by: Yann Liu <[email protected]>
TestDiscovery is flaky, because weighted load balancing is not 100% accurate and it often fails for 2 requests. Signed-off-by: Jacek Ewertowski <[email protected]>
a32ca35
to
9cf7201
Compare
Yes, I think we should incorporate the changes in |
7b40cfa
to
1feb335
Compare
/retest-required |
1feb335
to
93e2d0f
Compare
Custom values can be set through pilot environment variables. --------- Co-authored-by: Jonh Wendell <[email protected]>
93e2d0f
to
f9f0736
Compare
/test maistra-istio-unit-2-6 |
3 similar comments
/test maistra-istio-unit-2-6 |
/test maistra-istio-unit-2-6 |
/test maistra-istio-unit-2-6 |
@yannuil: No presubmit jobs available for maistra/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test maistra-istio-unit-2-6 |
1 similar comment
/test maistra-istio-unit-2-6 |
/retest-required |
Do we want |
@eoinfennessy yes, we do. |
1878937
into
maistra:maistra-2.6
No description provided.