Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download button for crowsnest.log and sonar.log #991

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Jul 31, 2022

Solves the following problem:

Fixes #979

This PR will add a download button for crowsnest.log and sonar.log:
image

Those button appear under the following conditions:
crowsnest.log exists in the logfile directory
sonar.log exists in the logfile directory and its filesize is greater than 0

Signed-off-by: Dominik Willner [email protected]

@dw-0 dw-0 requested a review from meteyou July 31, 2022 16:53
@dw-0 dw-0 added this to the v2.3.0 milestone Jul 31, 2022
@dw-0 dw-0 force-pushed the more-log-downloads branch from 14415ec to 75dcc2c Compare July 31, 2022 22:21
dw-0 added 2 commits August 1, 2022 00:21
Signed-off-by: Dominik Willner <[email protected]>
meteyou
meteyou previously approved these changes Jul 31, 2022
@dw-0 dw-0 merged commit 9474ae6 into mainsail-crew:develop Aug 1, 2022
@dw-0 dw-0 deleted the more-log-downloads branch August 1, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

According to service changes, display sonar.log and crowsnest.log button.
2 participants