Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale(nl): update dutch localization #861

Merged
merged 1 commit into from
May 30, 2022

Conversation

bartlammers
Copy link
Contributor

Some empty strings still in there, but those were empty in the en.json as well so kept them as such.

@dw-0 dw-0 changed the title locale(nl): Update NL locale for 2.2.0 locale(nl): update dutch localization May 29, 2022
Copy link
Member

@dw-0 dw-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fix with replacing the tabs with spaces as we require them.
There are a lot of empty strings in that file. So a lot of missing translations.
In the current english locale file are only 2 emptry strings. I this one are around 44.

style: lint and prettier

Signed-off-by: Dominik Willner <[email protected]>

locale(nl): remove empty strings
@bartlammers bartlammers force-pushed the feature/locale/dutch branch from 8c3ccc9 to 70d2052 Compare May 30, 2022 18:07
@bartlammers bartlammers requested a review from dw-0 May 30, 2022 18:11
@bartlammers
Copy link
Contributor Author

bartlammers commented May 30, 2022

Updated the translations, removed the empty strings (was because of BabelEdit, they apparently still existed in other languages) and re-ran lint and prettier.

Squashed the commits into 1

@dw-0
Copy link
Member

dw-0 commented May 30, 2022

Thank you, looks good to me now!

@meteyou meteyou merged commit 2113eae into mainsail-crew:develop May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants