Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show null RPM in temp chart (fixes #818) #820

Merged
merged 1 commit into from
May 18, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented May 17, 2022

This PR will correct an issue with the PrinterStateTemperatureObject interface.

object.rpm in TemperaturePanel.vue always returned a string because RPM got appended to the rpm value, which made a checking for !== null always be true.

Signed-off-by: Dominik Willner [email protected]

@dw-0 dw-0 linked an issue May 17, 2022 that may be closed by this pull request
@dw-0 dw-0 requested a review from meteyou May 17, 2022 07:42
@meteyou meteyou merged commit 76cedb1 into mainsail-crew:develop May 18, 2022
@dw-0 dw-0 deleted the fix-null-rpm branch May 19, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temp chart shows "null RPM" for fans w/o tachometer pins defined
2 participants