Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate checkbox for pwm fan (fixes #799) #802

Merged
merged 4 commits into from
May 15, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented May 13, 2022

This should fix #799

There was, what i assume, an issue during the construction of the dataset for the tempchart which led to duplicated pushes of the pwm fan name.

Lets say i had a pwm fan with the name my_pwm_fan, a dataset for my_pwm_fan and a dataset for my_pwm_fan-speed was added to the master dataset resulting in duplicated entries for the pwm checkbox and duplicated entries for the tempchart tooltip.

Signed-off-by: Dominik Willner [email protected]

@dw-0 dw-0 requested a review from meteyou May 13, 2022 12:51
meteyou
meteyou previously approved these changes May 13, 2022
@meteyou meteyou merged commit 9791202 into mainsail-crew:develop May 15, 2022
@dw-0 dw-0 deleted the fix-duplicate-pwm-fan-checkbox branch May 15, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWM Fan Flyout has dual check boxes for 'Show PWM speed in chart'
2 participants