Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(MachineSettingsPanel.vue): tweak visual appearance #784

Merged
merged 4 commits into from
May 9, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented May 9, 2022

  • MachineSettingsPanel.vue: change header to "Machine" only
  • MachineSettingsPanel.vue: remove sub panel from motion settings if no firmware retraction is enabled
  • MachineSettingsPanel.vue: use custom breakpoints instead of vuetify classes for finer breakpoint control
  • MotionSettings.vue: replace v-card-text wrapper with v-container
  • FirmwareRetractionSettings.vue: replace v-card-text wrapper with v-container

Signed-off-by: Dominik Willner [email protected]

dw-0 added 4 commits May 9, 2022 14:10
…ainer

will result in a 12px padding all around like everywhere else. v-card-text results in 16px which is inconsistent.

Signed-off-by: Dominik Willner <[email protected]>
… with v-container

will result in a 12px padding all around like everywhere else. v-card-text results in 16px which is inconsistent.

Signed-off-by: Dominik Willner <[email protected]>
- change header to "Machine" only
- fix: remove sub panel from motion settings if no firmware retraction is enabled

Signed-off-by: Dominik Willner <[email protected]>
use custom breakpoints instead of vuetify classes for finer breakpoint control

Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 requested a review from meteyou May 9, 2022 13:12
@dw-0 dw-0 merged commit 014a791 into mainsail-crew:develop May 9, 2022
@dw-0 dw-0 deleted the tweak-machine-settings-panel branch May 9, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants