-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locale(ja): add Japanese translation #774
Conversation
Thank you for your contribution. Sadly i am not allowed to push onto this PR and quickly fix it myself to make it merge-ready. |
Thanks for letting me know, I formatted it with Prettier Extension on Visual Studio Code, but the error did not go away. |
I see, im not quite sure if the issue is, that you committed the file with an indentation level of 2 spaces instead of 4. (we use 4 for locale json files) Can you now, after you already created the PR allow pushes to your branch from maintainers like me? Then i would try again and run prettier on that file on my machine too and try to fix that somehow. |
Thank you kindly for your detailed explanation. It seems that my Prettier Extension was not reading the configuration file properly so I fixed the problem in my environment and reformatted it. This seems to have solved the formatting problem. Thank you very much. |
Okay now it looks good! We can merge that. Thanks again for your contribution. |
Created Japanese translation