Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: indent size of 4 spaces in json #715

Merged
merged 2 commits into from
Mar 15, 2022
Merged

style: indent size of 4 spaces in json #715

merged 2 commits into from
Mar 15, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Mar 13, 2022

Signed-off-by: Dominik Willner [email protected]

@dw-0 dw-0 requested a review from meteyou March 13, 2022 21:52
@pataar
Copy link
Member

pataar commented Mar 15, 2022

I'd say, keep yml on two spaces. This is generally used as standard

@dw-0
Copy link
Member Author

dw-0 commented Mar 15, 2022

I'd say, keep yml on two spaces. This is generally used as standard

Im fine with that. So we should do it rather like this and split json and yaml?

[*.json]
indent_size = 4
indent_style = space

[*.yml]
indent_size = 2
indent_style = space

@pataar
Copy link
Member

pataar commented Mar 15, 2022

I'd say, keep yml on two spaces. This is generally used as standard

Im fine with that. So we should do it rather like this and split json and yaml?

[*.json]
indent_size = 4
indent_style = space

[*.yml]
indent_size = 2
indent_style = space

Perfect

@dw-0 dw-0 changed the title style: indent size of 4 spaces in json and yml style: indent size of 4 spaces in json Mar 15, 2022
@dw-0 dw-0 requested a review from pataar March 15, 2022 09:17
@dw-0 dw-0 requested review from meteyou and removed request for meteyou March 15, 2022 09:24
@dw-0 dw-0 merged commit cb0e40a into develop Mar 15, 2022
@dw-0 dw-0 deleted the th33xitus-patch-1 branch March 15, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants