Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make all MachineSettings use new NumberInput #651

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Feb 16, 2022

This PR will refactor the components used in the MachineSettings Panel to make use of the previously merged NumberInput.

New behavior to expect:

Input validation (optional):

22-02-16_20-19-46_brave
22-02-16_20-19-53_brave
Input validation can be deactivated if not wanted

Todo:


Signed-off-by: Dominik Willner [email protected]

Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 marked this pull request as ready for review February 28, 2022 14:18
@dw-0 dw-0 added the analyze runs build size report label Feb 28, 2022
@github-actions
Copy link
Contributor

Size Change: +347 B (0%)

Total Size: 1.79 MB

Filename Size Change
./dist/assets/Heightmap.js 120 kB -1 B (0%)
./dist/assets/index.js 248 kB +344 B (0%)
./dist/assets/index.css 56.4 kB -2 B (0%)
./dist/assets/Viewer.js 282 kB -1 B (0%)
./dist/index.html 691 B -1 B (0%)
./dist/sw.js 6.26 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/Codemirror.css 20 B
./dist/assets/Codemirror.js 113 kB
./dist/assets/Heightmap.css 283 B
./dist/assets/materialdesignicons-webfont.woff2 354 kB
./dist/assets/vendor.js 440 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.css 318 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-152x152.png 4.38 kB
./dist/img/icons/favicon-16x16.png 569 B
./dist/img/icons/favicon-32x32.png 1.05 kB
./dist/img/icons/icon-196-png 3.97 kB
./dist/img/icons/icon-512-png 11.1 kB
./dist/img/icons/mstile-150x150.png 4.26 kB
./dist/img/klipper.svg 3.4 kB
./dist/img/logo.svg 4.08 kB
./dist/img/sidebar-background.svg 1.33 kB

compressed-size-action

@dw-0 dw-0 requested a review from meteyou February 28, 2022 14:22
@dw-0 dw-0 removed the analyze runs build size report label Feb 28, 2022
@dw-0 dw-0 requested a review from meteyou February 28, 2022 22:51
@meteyou meteyou merged commit fef6ba3 into mainsail-crew:develop Feb 28, 2022
@dw-0 dw-0 deleted the refactor-inputs branch March 1, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants