Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pressure advance settings on dashboard #459

Merged
merged 10 commits into from
Dec 8, 2021

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Dec 7, 2021

Signed-off-by: Dominik Willner [email protected]

Signed-off-by: Dominik Willner <[email protected]>
* move pressure advance settings from PrintsettingsPanel to MachineSettingsPanel

Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 changed the title feature: pressure advance settings on dashboard feat: pressure advance settings on dashboard Dec 8, 2021
@meteyou meteyou merged commit abe66b4 into mainsail-crew:develop Dec 8, 2021
@dw-0 dw-0 deleted the feature/pa-settings branch December 9, 2021 23:05
@meteyou meteyou linked an issue Dec 14, 2021 that may be closed by this pull request
dw-0 added a commit to dw-0/mainsail that referenced this pull request Dec 25, 2021
* feat: pressure advance settings on dashboard

Signed-off-by: Dominik Willner <[email protected]>

* fix: motion setting input layout

Signed-off-by: Dominik Willner <[email protected]>

* fix: use restart icon instead of refresh icon

Signed-off-by: Dominik Willner <[email protected]>

* fix: fw retract settings input layout

Signed-off-by: Dominik Willner <[email protected]>

* refactor: move pressure advance settings

* move pressure advance settings from PrintsettingsPanel to MachineSettingsPanel

Signed-off-by: Dominik Willner <[email protected]>

* fix: hide spin buttons in fw retract input fields

Signed-off-by: Dominik Willner <[email protected]>

* fix: hide spin buttons in pa input fields

Signed-off-by: Dominik Willner <[email protected]>

* refactor: class assignment conditions in pa settings

Signed-off-by: Dominik Willner <[email protected]>

* chore: define function return types

Signed-off-by: Dominik Willner <[email protected]>

* refactor: remove unused imports

Signed-off-by: Stefan Dej <[email protected]>

Co-authored-by: Stefan Dej <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]Sliders for adjusting PA and smooth_time
2 participants