-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification): add TMC overheating warnings #1919
Merged
meteyou
merged 4 commits into
mainsail-crew:develop
from
meteyou:feat/add-tmc-ot-warnings
Jul 6, 2024
Merged
feat(notification): add TMC overheating warnings #1919
meteyou
merged 4 commits into
mainsail-crew:develop
from
meteyou:feat/add-tmc-ot-warnings
Jul 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <[email protected]>
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Jun 23, 2024
Language file analysis report:
|
dw-0
reviewed
Jul 6, 2024
dw-0
reviewed
Jul 6, 2024
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
dw-0
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a warning for OTPW flag and a critical notification for OT flag. OTPW is a Over Temperature Pre-Warning and OT is a Over Temperature flag from TMC drivers.
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?
none