fix: fix commit list view on desktop and mobile devices #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
rackrick
approved these changes
Feb 17, 2024
meteyou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just fix some UI issues in the commit list in the update manager. It add a min height on desktop devices and switch to fullscreen on mobile devices. on mobile devices i also changed the margin on the left side with the line and also put the hash of the commit at the bottom to have a single col layout inside of the commit.
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
before on desktop with less entries:
after on desktop with less entries:
before on mobile with less entries:
after on mobile with less entries:
after on mobile with more entries:
[optional] Are there any post-deployment tasks we need to perform?