fix: hide rpm in temperature_fans without tachometer_pin #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <[email protected]>
rackrick
approved these changes
Jul 26, 2023
Zeanon
added a commit
to LynxCrew/mainsail
that referenced
this pull request
Jul 30, 2023
commit 1b763e2 Merge: 4d241fc 1a12554 Author: Stefan Dej <[email protected]> Date: Sun Jul 30 21:23:05 2023 +0200 [Automated] Merged develop into target master commit 1a12554 Author: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Sun Jul 30 19:22:55 2023 +0000 chore: push version number to v2.6.2 commit 7251a8c Author: Zhu Qian <[email protected]> Date: Mon Jul 31 03:17:39 2023 +0800 locale(zh): update chinese locale (mainsail-crew#1486) Co-authored-by: Stefan Dej <[email protected]> commit cda3098 Author: Stefan Dej <[email protected]> Date: Sun Jul 30 21:03:00 2023 +0200 fix: fix issue with cannot extrude after a Klipper restart (mainsail-crew#1495) commit 9eb133b Author: Stefan Dej <[email protected]> Date: Sun Jul 30 21:02:28 2023 +0200 fix: fix multiple issues in the refactored update manager (mainsail-crew#1497) commit 6a4cca7 Author: Stefan Dej <[email protected]> Date: Sun Jul 30 21:01:05 2023 +0200 fix: fix issue with create/edit presets and refactor settings (mainsail-crew#1499) commit d67ef3a Author: Stefan Dej <[email protected]> Date: Sun Jul 30 12:41:08 2023 +0200 fix: use webcam name instead of UUID for timelapse plugin (mainsail-crew#1492) commit aeee198 Author: Stefan Dej <[email protected]> Date: Fri Jul 28 22:48:01 2023 +0200 fix: fix issue with camel-case object names in temperature panel (mainsail-crew#1491) commit 5c40820 Author: Stefan Dej <[email protected]> Date: Thu Jul 27 23:02:51 2023 +0200 fix: fix flip function in several webcam clients (mainsail-crew#1487) commit e929c7c Author: Stefan Dej <[email protected]> Date: Thu Jul 27 09:42:07 2023 +0200 fix: hide rpm in temperature_fans without tachometer_pin (mainsail-crew#1489) commit 0b47a80 Author: Stefan Dej <[email protected]> Date: Mon Jul 24 22:13:16 2023 +0200 refactor: refactor SettingsRow (mainsail-crew#1484) commit 8447be2 Author: Stefan Dej <[email protected]> Date: Mon Jul 24 22:08:50 2023 +0200 fix: fix editor save & restart button behavior (mainsail-crew#1483) commit 0c5aca8 Author: Daviteusz <[email protected]> Date: Mon Jul 24 19:27:21 2023 +0200 locale(pl): Update Polish translation (mainsail-crew#1482) commit eceb442 Author: meteyou <[email protected]> Date: Mon Jul 24 07:36:14 2023 +0000 docs(changelog): update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the last refactoring of the temperature panel is a bug, which display
NaN RPMwhen your temperature_fan has no tachometer.Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
none
[optional] Are there any post-deployment tasks we need to perform?
none