fix: Make the correct notification appear on gcode file move #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong notification was being displayed when moving a file.
meteyou
reviewed
May 4, 2023
meteyou
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wrong notification was being shown when moving a file, this PR makes sure that the "file move" toast shows when we move a file instead of the rename toast.
Mobile & Desktop Screenshots/Recordings
Before
Screen.Recording.2023-05-04.at.2.31.45.PM.mov
After
Screen.Recording.2023-05-04.at.2.32.20.PM.mov
[optional] Are there any post-deployment tasks we need to perform?
No post deployment tasks.