feat: Add printer name to browser tab while printing or complete

[mikebcbc]

Adds the printer name to the browser tab during printing and complete statuses.

Description

This PR addresses #1322 and adds the printer name to the browser tab while the printer is printing, or when the print is complete.

Related Tickets & Documents

#1322

Mobile & Desktop Screenshots/Recordings

[optional] Are there any post-deployment tasks we need to perform?

No post-deployment tasks.

[github-actions]

Language file analysis report:

File	Missing Keys	Unused Keys
en.json	0	0

[meteyou]

Thx for your PR. I have only one question about it. What happens when the user don't set a printername in the settings?

[github-actions]

Language file analysis report:

File	Missing Keys	Unused Keys
da.json	6	0
de.json	2	0
en.json	0	0
ko.json	146	2

[mikebcbc]

Thx for your PR. I have only one question about it. What happens when the user don't set a printername in the settings?

@meteyou - good question, I updated this PR to handle that. Before it would just show the hyphen, but now I am conditionally showing the hyphen. Take a look at the PR. Here's two examples:

printername defined:

printername not defined:

[github-actions]

Language file analysis report:

File	Missing Keys	Unused Keys
da.json	6	0
de.json	2	0
en.json	0	0
ko.json	146	2

[github-actions]

Language file analysis report:

File	Missing Keys	Unused Keys
da.json	6	0
de.json	2	0
en.json	0	0
ko.json	146	2

[meteyou]

hmm... maybe my "idea" with adding the {name} in the translation itself was wrong for this use case. maybe you should just use getter to add " - ", when it exists and we also don't have an issue with the "new" translation keys.

[github-actions]

Language file analysis report:

File	Missing Keys	Unused Keys
da.json	9	3
de.json	5	3
en.json	0	0
ko.json	149	5

[mikebcbc]

hmm... maybe my "idea" with adding the {name} in the translation itself was wrong for this use case. maybe you should just use getter to add " - ", when it exists and we also don't have an issue with the "new" translation keys.

@meteyou Are you saying to force it in the getter? Like this:

return i18n.t('App.Titles.PrintingETA', {
                    percent: percent,
                    filename: state.printer?.print_stats?.filename,
                    eta
                }) + state.gui?.general.printername ? `- ${state.gui?.general.printername}` : ""

If so, I feel like that's not very clean... I feel like it would be cleaner to just supply the - {name} and update the translation keys. If we don't want to worry about translation, since it's all the same no matter the language I can just update every translation and append this where it fits... what are you thoughts on that?

[meteyou]

i would use write it a little bit different (just for readability):

let output = i18n.t('App.Titles.PrintingETA', {
	                    percent: percent,
	                    filename: state.printer?.print_stats?.filename,
	                    eta
	                })

// add printer name if it exists
if (state.gui?.general.printername) output += ` - ${state.gui.general.printername}`

return output

I just don't like to add "decorators" in a translation variable.

just my 2 cents about this topic...
(my solution have not to be the best way... its just my style to do it...)

[mikebcbc]

@

i would use write it a little bit different (just for readability):

let output = i18n.t('App.Titles.PrintingETA', {
	                    percent: percent,
	                    filename: state.printer?.print_stats?.filename,
	                    eta
	                })

// add printer name if it exists
if (state.gui?.general.printername) output += ` - ${state.gui.general.printername}`

return output

I just don't like to add "decorators" in a translation variable.

just my 2 cents about this topic... (my solution have not to be the best way... its just my style to do it...)

@meteyou - I think that makes sense. I think it does all come down to style - looks clean to me. I updated this PR and removed it from the translation keys. Let me know what you think! Thanks for the clarification!

[mikebcbc]

@meteyou - anything else you need from me on this PR, or is it good to go?

[meteyou]

LGTM! Thanks!

[wikolii]

Hi, is there any way one could choose to have the machine name in front of the tab description?
In my case I normally just print the same part in many printers and having to wait for the popup with the full tab description to know the machine name is time consuming.

I would even choose not to have the filename on the tab description, maybe there could be some setting for that.
Thanks!