Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add gcode offset to live position in gcodeviewer #1341

Merged
merged 2 commits into from
Apr 30, 2023
Merged

fix: add gcode offset to live position in gcodeviewer #1341

merged 2 commits into from
Apr 30, 2023

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Apr 17, 2023

No description provided.

@meteyou meteyou requested review from dw-0 and zellneralex April 17, 2023 18:56
zellneralex
zellneralex approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@zellneralex zellneralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the V400 with a large negativ gcode offset. Looks good now.

image

@meteyou meteyou merged commit ab777d5 into mainsail-crew:develop Apr 30, 2023
@meteyou meteyou deleted the fix/gcode-offset-in-gcodeviewer branch April 30, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zellneralex zellneralex zellneralex approved these changes

@dw-0 dw-0 dw-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meteyou @dw-0 @zellneralex