fix(build): fix log file upload #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Wendel <[email protected]>
* Set order to previous locations Signed-off-by: Stephan Wendel <[email protected]>
Will be removed after testing, due revert Signed-off-by: Stephan Wendel <[email protected]>
Signed-off-by: Stephan Wendel <[email protected]>
This reverts commit 2829fe2.
KwadFan
changed the title
meteyou
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in this example run: https://github.com/mainsail-crew/MainsailOS/actions/runs/8959578689 ,
an error occurs during the phase to upload the build log.
The issue is introduced due the failing Rename Image step. Because, if the build fails there is no according image to rename, which results in an empty
IMAGEenvironment variable. This leads to an incorrect renamed log file andalso duplicates failing steps which should not executed if build fails.
Therefor changing the order of steps, triggers and naming of log file.