Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for ember-cli-babel v7 #1212

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,18 @@ module.exports = {

appOrParent.options = appOrParent.options || {};

if (checker.satisfies('^6.0.0-beta.1') || checker.satisfies('^7.0.0')) {
if (checker.satisfies('^6.0.0-beta.1')) {
appOrParent.options.babel6 = appOrParent.options.babel6 || {};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The babel6 key is not used anymore in ember-cli-babel v7

appOrParent.options.babel6.plugins = appOrParent.options.babel6.plugins || [];
appOrParent.options.babel6.plugins.push(
require.resolve('./strip-data-test-properties-plugin6')
);
} else if (checker.satisfies('^7.0.0')) {
appOrParent.options.babel = appOrParent.options.babel || {};
appOrParent.options.babel.plugins = appOrParent.options.babel.plugins || [];
appOrParent.options.babel.plugins.push(
require.resolve('./strip-data-test-properties-plugin6')
);
} else {
this.ui.writeWarnLine(
'ember-test-selectors: You are using an unsupported ember-cli-babel version. data-test ' +
Expand Down