-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process groups #94
base: develop
Are you sure you want to change the base?
Conversation
@ahukkanen I tested Elie's branch and it works for me in local 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks much safer now! Maybe @paulinebessoles can test again whether everything still works as expected?
Sorry for the late reply! I tested again and it works for me 😁 @eliegaboriau could you update your branch so it matches the main branch recent commits? |
…rm_customizer into add_process_groups
It should be okay now ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions.
Overal looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thank you very much for your great contribution @eliegaboriau!
I have tested this locally and it worked great. I could edit the strings in the participatory group page and when scoping the translation set only to a participatory group through the constraints.
However, there are some issues making tight coupling with the decidim-participatory_processes
module with this one. Could you please have another look and see if there is a way to abstract that away, to make the module also usable when the decidim-participatory_processes
module is not installed. We have one of those instances we are hosting ourselves.
I would like to keep this module separate from the decidim-participatory_processes
to avoid tight coupling.
Another issue I had was with the ApplicationHelper
being included everywhere, so please also see that comment below.
Hello @ahukkanen, thanks for your review !
|
@ahukkanen Is this solution right for you? |
This PR allows admins to add constraints about process groups.
It could closes #75 and it is based on those specs