Fix/styles #118
Open
Fix/styles #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript entrypoints to target methods to their own views
…er into fix/styles
ahukkanen
requested changes
Apr 18, 2024
package-lock.json
Outdated
| @@ -26,7 +30,12 @@ | |||
| "eslint-plugin-promise": "^3.8.0", | |||
| "eslint-plugin-react": "^7.20.6", | |||
| "eslint-plugin-standard": "^3.1.0", | |||
| "sass-embedded": "~1.57.1", | |||
There was a problem hiding this comment.
Can you extract the package.json related changes to another PR?
Gemfile.lock
Outdated
| @@ -8,63 +8,63 @@ PATH | |||
| GEM | |||
| remote: https://rubygems.org/ | |||
| specs: | |||
| actioncable (6.1.7.6) | |||
There was a problem hiding this comment.
Can you extract the Gemfile.lock related changes to another PR?
| @@ -5,6 +5,7 @@ module TermCustomizer | |||
| module Admin | |||
| # This controller is the abstract class from which all other controllers | |||
| # of this engine inherit. | |||
|
|
|||
| @@ -63,7 +63,7 @@ module Admin | |||
| upload_test_file( | |||
| Rack::Test::UploadedFile.new( | |||
| file_fixture("set-translations.json"), | |||
| "text/plain" | |||
| "text/html" | |||
There was a problem hiding this comment.
I believe the correct MIME type for a JSON is application/json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing style changes for Decidim Version 0.28. Also changes the structure of JavaScript entrypoints to prevent unnecessary loading of JS code in views where it's not needed.
Also adds the breadcrumb functionality for module's page.