Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/import excel error with nil header cells #113

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sinaeftekhar
Copy link
Contributor

Sometimes the excel files might contain nil values which is not evident to the users eye, but messes with the app.
This fix solves this problem.
Fixes issue #91

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (abbf0c6) 96.79% compared to head (90e08d6) 96.71%.
Report is 7 commits behind head on master.

Files Patch % Lines
lib/decidim/term_customizer/import/readers/xlsx.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   96.79%   96.71%   -0.08%     
==========================================
  Files          58       58              
  Lines        1153     1157       +4     
==========================================
+ Hits         1116     1119       +3     
- Misses         37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant