fix: Devise email translation customization

[Quentinchampenois]

Description

Current version does not allow to translate Devise emails translations (subjects, etc...)

Decidim::TermCustomizer::Context::JobContext doesn't handle the Devise job arguments format. At the moment, it expects Decidim jobs to have as argument a Decidim::Organization or Decidim::User in method resolve!.

I found that Devise mailer jobs contains a list of arguments and the expected argument in a Hash { args: [Decidim::User] } for example.

Related to

• Unable to translate devise mails #93

How to test

Create multiple devise translation customizations :

For account confirmation mails :

Create TermCustomizer entries

• devise.mailer.confirmation_instructions.instruction
• devise.mailer.confirmation_instructions.subject

Refresh cache and create a new account

For reset password confirmation :
Create TermCustomizer entries

• devise.mailer.reset_password_instructions.subject

Refresh cache and ask a reset password for [email protected]

For new admin invitation
Create TermCustomizer entries

• devise.mailer.invite_admin.subject

Refresh cache and invite a new admin

[AyakorK]

Hello @Quentinchampenois, we've noticed on few applications containing this branch on their Gemfile that we had an issue with the sending of notifications due to this line

arg = arg[:args].first if arg.is_a?(Hash)

We may need to identify the reason of the issue as soon as possible and find an alternative to this fix.

[sinaeftekhar]

Thanks for your review.
Your PR solves the issue. I left a comment.

[sinaeftekhar]

I would suggest adding a comment(i.e with a reference to #93).
Also, I would move this line of code to organization_from_argument method, so as to affect only organization setting

[Quentinchampenois]

Thank you for your review, I convert to draft and re-open it once I implemented your suggestion !

[Quentinchampenois]

I can move this line in organization_from_argument method but I wonder if we should also keep it for space_from_argument and component_from_argument because all these methods takes arg as argument

[Quentinchampenois]

Hello, I will work on resolving conflicts asap

About the change request, should I move the line :
arg = arg[:args].first if arg.is_a?(Hash) && arg.has_key?(:args)

In the following methods : organization_from_argument, space_from_argument, component_from_argument or I keep it as it ?