Fix database not available (Zeitwerk and Docker error) #103
Conversation
armandfardeau
force-pushed
the
fix/precompile-on-docker
branch
from
508805d to
228a491
Compare
armandfardeau
force-pushed
the
fix/precompile-on-docker
branch
from
228a491 to
6a610dd
Compare
armandfardeau
changed the title
armandfardeau
force-pushed
the
fix/precompile-on-docker
branch
from
6a610dd to
770b390
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #103 +/- ##
========================================
Coverage 96.79% 96.79%
========================================
Files 58 58
Lines 1153 1153
========================================
Hits 1116 1116
Misses 37 37
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Dear @armandfardeau
Many thanks for the PR. There are couple of typos, which I made a comment on those.
| @@ -78,6 +78,22 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "when the translation query raises ActiveRecord::StatementInvalid" do | |||
| it "returns and empty result" do | |||
There was a problem hiding this comment.
I think you mean an, not and
| end | ||
|
|
||
| context "when there is no database connection" do | ||
| it "returns and empty result" do |
There was a problem hiding this comment.
I think you mean an, not and
|
Hello @sinaeftekhar, If the change request only concerns typos in tests I can open a new PR to fix typos because I don't have write rights on the @armandfardeau's fork |
|
Hello, this PR won't be continued here but I can apply change request on a new one if needed FYI, we already use this fix on our fork for containerized apps |
This modules use a database for initialization but in some cases (Zeitwerk checks or precompilation of assets on Docker) a database is not available.
This P.R. allows usage in theses cases.