Add tests for the fix

mainio · Jan 3, 2024 · 90e08d6 · 90e08d6
1 parent 0a08389
commit 90e08d6
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/lib/decidim/term_customizer/import/importer.rb b/lib/decidim/term_customizer/import/importer.rb
@@ -52,9 +52,7 @@ def collection_data
           data_headers = []
           reader.new(file).read_rows do |rowdata, index|
             if index.zero?
-              data_headers = rowdata.map do |cell|
-                cell.to_sym if cell.present?
-              end
+              data_headers = rowdata.compact_blank.map(&:to_sym)
             else
               next if rowdata.blank?
 

diff --git a/spec/fixtures/files/set-translations-with-nils.xlsx b/spec/fixtures/files/set-translations-with-nils.xlsx
diff --git a/spec/lib/decidim/term_customizer/import/readers/xlsx_spec.rb b/spec/lib/decidim/term_customizer/import/readers/xlsx_spec.rb
@@ -10,6 +10,6 @@
   context "with xlsx files containing nils in header" do
     let(:file) { file_fixture("set-translations-with-nils.xlsx") }
 
-  it_behaves_like "translation import reader"
+    it_behaves_like "translation import reader"
   end
 end
diff --git a/spec/shared/translation_importer_examples.rb b/spec/shared/translation_importer_examples.rb
@@ -97,7 +97,7 @@
   it "yields all the data correctly" do
     data = []
     subject.read_rows do |row, index|
-      data[index] = row.map(&:to_s)
+      data[index] = row.compact_blank.map(&:to_s)
     end
 
     expected_array = []