Fixed Lookup() bug #174
Merged
Fixed Lookup() bug #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jvb182
approved these changes
Jun 16, 2023
MatthewEdge
approved these changes
Jun 16, 2023
Takumi2008
approved these changes
Jun 17, 2023
horkhe
reviewed
Jun 19, 2023
mxresolv/mxresolv.go
Outdated
| if len(mxHosts) == 0 { | ||
| return cacheAndReturn(hostname, nil, nil, false, errNoValidMXHosts) | ||
| } | ||
| return cacheAndReturn(hostname, mxHosts, mxRecords, false, nil) | ||
| } | ||
|
|
||
| func shuffleMXRecords(mxRecords []*net.MX) []string { | ||
| func ShuffleMXRecords(mxRecords []*net.MX) []string { |
There was a problem hiding this comment.
Why did you make it a public function?
There was a problem hiding this comment.
Because I don't like writing tests for private methods. 😮💨 But in this case, I don't wanna do the correct thing and embed a DNS server we can query to retrieve proper MX records for testing. Instead we use publicly hosted MX records which don't have the specific regression configuration I wanted to target. So I made the method public and added tests for it.
I understand your position on this so I reverted and made the method private. 👍
thrawn01
force-pushed
the
thrawn/mx-host-bug
branch
from
006a3f9
to
15c378e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In situations where a recipient domain resolved with 2 MX hosts of the same priority only one host would be returned from
Lookup()Implementation
ShuffleMXRecords()would not consider the final entry in a list of MX records if there were only 2 entries. This change correctly identifies when the loop is on the last MX record.