Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getAll, find and changeName methods #123

Merged
merged 3 commits into from
May 27, 2024

Conversation

Nyanko-sensei
Copy link
Contributor

resolves #2107

Changelist

  • Added a method to show all tokens get all
  • Added a method to show single api token info find
  • Added a method to change token name changeName

Testing/QA

  • Open deployed branch

How to release

  • none extra steps

PR Checklist

  • Tests are done and pass
  • No PHP and JS errors
  • PR does not go out of scope of the task
  • Possible breaking changes are documented in the PR

Screenshots

not applicable

Risks

None at this point

Additional notes

It goes with other PR in docs and php-sdk

@Nyanko-sensei Nyanko-sensei requested a review from a team as a code owner April 18, 2024 12:31
src/Endpoints/Token.php Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Nyanko-sensei Nyanko-sensei requested review from JoaoFSCruz and PeterOcansey and removed request for JoaoFSCruz May 13, 2024 08:21
@fosron fosron requested review from JoaoFSCruz and removed request for JoaoFSCruz May 14, 2024 11:01
Copy link
Contributor

@PeterOcansey PeterOcansey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few clean up

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fosron fosron dismissed JoaoFSCruz’s stale review May 16, 2024 06:35

Not relevant anymore

@Nyanko-sensei Nyanko-sensei requested a review from JoaoFSCruz May 22, 2024 08:33
@Nyanko-sensei Nyanko-sensei merged commit 6833863 into main May 27, 2024
5 checks passed
@Nyanko-sensei Nyanko-sensei deleted the feature/issue-2107/add_token_api_endpoints branch May 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants