Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if apc is disabled during ownCloud setup, if so enable it #983

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

yodax
Copy link
Contributor

@yodax yodax commented Oct 19, 2016

I was able to reproduce the issue reported in the ownCloud 9.1.1 PR. If I change my config to disable apc, I get the same error message. Running the setup with this PR fixes the problem.

I check if it is explicitly disabled otherwise I do nothing, it might be enabled somewhere else.

@JoshData
Copy link
Member

editconf is idempotent so it should be safe to use it without the if block around it?

@yodax
Copy link
Contributor Author

yodax commented Oct 21, 2016

I put the if block there because the setting can be enabled in more than one place. My original config file didn't contain the setting. It is in another file.

@JoshData
Copy link
Member

I don't understand....

@yodax
Copy link
Contributor Author

yodax commented Oct 24, 2016

This option can be set in 2 places;

  • /etc/php5/mods-available/apcu.ini
  • /etc/php5/fpm/php.ini

I didn't want to build an option that sets it in both locations, just remove the explicit disable from the modules configuration. That's not the place where I would normally enable the setting. It is enabled by default. To enable it for fpm I would set it in that ini.

I don't think it will hurt to remove the if block, I just think it isn't pretty to do that.

@JoshData
Copy link
Member

Ahhha. Makes sense.

@JoshData JoshData merged commit 2b00478 into mail-in-a-box:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants