Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Travis + Tabbar): Replace react-icons with antD icons in TabBar #455

Closed
wants to merge 6 commits into from

Conversation

shriram2301
Copy link
Contributor

@shriram2301 shriram2301 commented Dec 6, 2018

resolves #397
resolves #455

@shriram2301 shriram2301 changed the title feat(TabBar): replace react-icons with antD icons feat(TabBar): replace react-icons with antD icons in TabBar Dec 6, 2018
@bochaco bochaco added this to the next milestone Dec 10, 2018
@shriram2301 shriram2301 force-pushed the reactIconsToAntD branch 3 times, most recently from ef880d5 to af2bf94 Compare December 12, 2018 14:03
@joshuef
Copy link
Collaborator

joshuef commented Dec 17, 2018

@shriram2301 I'm confused. Is this PR now replacing (#449) ? For getting widows in travis?

If so can you update the naming of this / close the other, please.

And then let's also remove appveyor.yml from this branch.

Cheers!

@shriram2301 shriram2301 force-pushed the reactIconsToAntD branch 2 times, most recently from 9506a3a to e5b4288 Compare December 19, 2018 16:21
@shriram2301 shriram2301 added the to review ready for review label Dec 20, 2018
@joshuef
Copy link
Collaborator

joshuef commented Dec 21, 2018

@shriram2301 have you posted to the travis windows forum about the windows issue?

Can you link me please.

@shriram2301
Copy link
Contributor Author

@shriram2301 have you posted to the travis windows forum about the windows issue?

Can you link me please.

https://travis-ci.community/t/yarn-run-build-failure-in-windows-when-node-env-set-to-dev/1588

this is the link to the issue I raised in Travis forum

@joshuef
Copy link
Collaborator

joshuef commented Jan 3, 2019

As per yarnpkg/yarn#5055 have you tried running yarn verbose @shriram2301 ?

@shriram2301
Copy link
Contributor Author

Options I have tried so far to get yarn run build working

  • yarn run build
  • yarn build
  • travis_retry eval "yarn run build"
  • travis_retry eval "yarn build"
  • travis_wait travis_retry eval "yarn build"
  • travis_wait travis_retry eval "yarn run build"
  • travis_wait yarn build
  • travis_wait yarn run build
  • travis_retry yarn build
  • travis_retry yarn run build

@shriram2301 shriram2301 removed to review ready for review labels Jan 9, 2019
@shriram2301
Copy link
Contributor Author

shriram2301 commented Jan 10, 2019

As per yarnpkg/yarn#5055 have you tried running yarn verbose @shriram2301 ?

I tried doing this by running yarn build --verbose it still doesn't work for windows dev alone for reference please see https://travis-ci.org/maidsafe/safe_browser/jobs/477366449

@joshuef joshuef modified the milestones: 0.11.1, Next Jan 17, 2019
@joshuef joshuef self-assigned this Jan 17, 2019
@joshuef joshuef changed the title feat(TabBar): replace react-icons with antD icons in TabBar feat(Travis + Tabbar): Replace react-icons with antD icons in TabBar/. Update Travis for windows Jan 23, 2019
@joshuef
Copy link
Collaborator

joshuef commented Mar 14, 2019

Closing as this as been usurped by other windows test branches

@joshuef joshuef closed this Mar 14, 2019
@joshuef joshuef changed the title feat(Travis + Tabbar): Replace react-icons with antD icons in TabBar/. Update Travis for windows feat(Travis + Tabbar): Replace react-icons with antD icons in TabBar Apr 10, 2019
@joshuef joshuef mentioned this pull request Apr 10, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from AppVeyor to Travis
3 participants