Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): updates AppVeyor and Travis CI to pull file resources #274

Closed
wants to merge 2 commits into from
Closed

Conversation

hunterlester
Copy link
Contributor

@joshuef PR updated to include AppVeyor config.
Published released based on tag push: https://github.com/hunterlester/safe_browser/releases/tag/peruse2

@hunterlester hunterlester added the to review ready for review label Jul 17, 2018
joshuef
joshuef previously approved these changes Jul 17, 2018
@hunterlester hunterlester added bug and removed to review ready for review labels Jul 20, 2018
@bochaco
Copy link
Contributor

bochaco commented Aug 8, 2018

@hunterlester @joshuef , I'm not sure what's the state of this, is this still ok to merge?

@bochaco bochaco removed the bug label Aug 8, 2018
@hunterlester
Copy link
Contributor Author

@bochaco Still investigating why Github credentials are working on AppVeyor but not on Travis for pulling for release_config. This was put on pause to address other tasks.

@hunterlester
Copy link
Contributor Author

hunterlester commented Oct 4, 2018

When building on my fork of safe_browser in AppVeyor, the Github credentials used to pull from the release_config repository are successful.
However when building from this repository in AppVeyor, Invoke-WebRequest returns 401 Unauthorized.
I need help understanding why this is the case.
Same exact access_token being used.

Travis builds between my fork and this repository are fine, when using the same credentials to pull from release_config.

@hunterlester hunterlester changed the base branch from peruse to master November 20, 2018 00:56
@hunterlester hunterlester changed the title MAID-2847 chore/CI: updates AppVeyor and Travis CI to pull file resources chore(CI): updates AppVeyor and Travis CI to pull file resources Nov 29, 2018
@hunterlester
Copy link
Contributor Author

Resolves #440

@hunterlester
Copy link
Contributor Author

I'll resume work on this once #397 is complete, which involves deprecating the use of so-called secure environment variables in Travis.

@joshuef
Copy link
Collaborator

joshuef commented Nov 30, 2018

just to be clear, this isnt ready for review then @hunterlester ? If that's true can you update the col in the project please.

If it is ready... What are we calling success here? I'm not sure what to be checking for.

@hunterlester hunterlester deleted the 2847 branch March 22, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants