Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking http url from safe site twice, the page goes two steps back #689

Closed
safesurfer opened this issue Apr 23, 2019 · 2 comments
Closed

Comments

@safesurfer
Copy link
Contributor

safesurfer commented Apr 23, 2019

When I click http url once, in safe://safenetworkprimer it shows the error popup, but if I click the same link twice, the page goes two steps back, if I click thrice, goes three steps back, and so on.

STR:

  1. Open browser and a new tab, access some safe site which has http links, eg: safe://safenetworkprimer
  2. click some chapter, and click http link. It shows error popup saying the url is blocked
  3. try click the same link twice, it goes two steps back, which is the home page safe://safenetworkprimer
  4. try click the same link thrice, it goes three steps back, which is about:blank and so on.
@joshuef
Copy link
Collaborator

joshuef commented Apr 23, 2019

Ah, the actual issue here seems to be clicking the same link twice throws an error for a safe: link, which it should not (and is then sending us back in the history)

joshuef added a commit to joshuef/sn_browser that referenced this issue Apr 23, 2019
Ensures that error link is the same as current link before firing tabBackwards.

Fixes maidsafe#689
@safesurfer
Copy link
Contributor Author

QA verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants