fix: step should always be a number value not string

mahyarmirrashed · Nov 6, 2023 · d54c11d · d54c11d
1 parent e62e602
commit d54c11d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 20 deletions.
diff --git a/src/lib/slots/DayOfWeekSlot.ts b/src/lib/slots/DayOfWeekSlot.ts
@@ -31,11 +31,11 @@ class DayOfWeekSlot extends BaseSlot implements IBaseSlot<number | DayString> {
     );
   }
 
-  override addStep<T extends number | DayString>(step: T, start: T = 0 as T) {
-    return super.addStep(
-      this.valueConverter.convertToNumber(step),
-      this.valueConverter.convertToNumber(start),
-    );
+  override addStep<T extends number | DayString>(
+    step: number,
+    start: T = 0 as T,
+  ) {
+    return super.addStep(step, this.valueConverter.convertToNumber(start));
   }
 
   override removeSingle<T extends number | DayString>(value: T) {
@@ -50,13 +50,10 @@ class DayOfWeekSlot extends BaseSlot implements IBaseSlot<number | DayString> {
   }
 
   override removeStep<T extends number | DayString>(
-    step: T,
+    step: number,
     start: T = 0 as T,
   ) {
-    return super.removeStep(
-      this.valueConverter.convertToNumber(step),
-      this.valueConverter.convertToNumber(start),
-    );
+    return super.removeStep(step, this.valueConverter.convertToNumber(start));
   }
 }
 

diff --git a/src/lib/slots/MonthSlot.ts b/src/lib/slots/MonthSlot.ts
@@ -53,11 +53,11 @@ class MonthSlot
     );
   }
 
-  override addStep<T extends number | MonthString>(step: T, start: T = 1 as T) {
-    return super.addStep(
-      this.valueConverter.convertToNumber(step),
-      this.valueConverter.convertToNumber(start),
-    );
+  override addStep<T extends number | MonthString>(
+    step: number,
+    start: T = 1 as T,
+  ) {
+    return super.addStep(step, this.valueConverter.convertToNumber(start));
   }
 
   override removeSingle<T extends number | MonthString>(value: T) {
@@ -72,13 +72,10 @@ class MonthSlot
   }
 
   override removeStep<T extends number | MonthString>(
-    step: T,
+    step: number,
     start: T = 1 as T,
   ) {
-    return super.removeStep(
-      this.valueConverter.convertToNumber(step),
-      this.valueConverter.convertToNumber(start),
-    );
+    return super.removeStep(step, this.valueConverter.convertToNumber(start));
   }
 }