Fix the bug with single-slice pie

mahozad · Aug 25, 2021 · d79fdf1 · d79fdf1
1 parent cbd2c21
commit d79fdf1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/piechart/src/androidTest/assets/screenshot-72.png b/piechart/src/androidTest/assets/screenshot-72.png
diff --git a/piechart/src/androidTest/kotlin/ir/mahozad/android/ScreenshotTest.kt b/piechart/src/androidTest/kotlin/ir/mahozad/android/ScreenshotTest.kt
@@ -596,6 +596,12 @@ class ScreenshotTest {
         }
     }
 
+    @Test fun chartWithASingleSlice() {
+        compareScreenshots("screenshot-72") {
+            slices = listOf(Slice(1f, Color.rgb(133, 77, 206)))
+        }
+    }
+
     /**
      * FIXME: the name of the function is misleading. It also works in a saving
      *  mode in that it just saves the screenshot on device and skips the comparison.

diff --git a/piechart/src/main/kotlin/ir/mahozad/android/component/Pie.kt b/piechart/src/main/kotlin/ir/mahozad/android/component/Pie.kt
@@ -144,7 +144,11 @@ internal class Pie(
             mainPaint.shader = gradient
             mainPaint.alpha = 255
 
-            val slicePath = makeSlice(center, pieEnclosingRect, currentAngle, slice.fraction, pieDrawDirection, slice.pointer ?: slicesPointer)
+            val slicePath = if (slice.fraction == 1f) {
+                Path().apply { addCircle(center.x, center.y, radius, Path.Direction.CW) }
+            } else {
+                makeSlice(center, pieEnclosingRect, currentAngle, slice.fraction, pieDrawDirection, slice.pointer ?: slicesPointer)
+            }
             canvas.withClip(clip) {
                 canvas.drawPath(slicePath, mainPaint)
             }