Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more redundant internal compatibility aliases #366

Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Apr 21, 2024

Noticed in python/typeshed#11804 . Follow-up to #362

idk if you'd like to drop tests for total_ordering since boltons is no longer implementing it.

@mahmoud
Copy link
Owner

mahmoud commented Jun 30, 2024

Hey @Avasam just circling back to this, this is great. A really good start to leaving the dust of 2 behind. Seems like the total_ordering tests at least work as a check that the symbol's there for backwards compat. Seems fast enough and pretty unlikely to change, right? Thanks again!

@mahmoud mahmoud merged commit 9381c52 into mahmoud:master Jun 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants