Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optional Scroll Controller #199

Merged
merged 7 commits into from
Dec 24, 2024
Merged

Add Optional Scroll Controller #199

merged 7 commits into from
Dec 24, 2024

Conversation

OUFA217
Copy link
Contributor

@OUFA217 OUFA217 commented Dec 20, 2024

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing using flutter test

If you need help, consider pinging the maintainer @maheshj01

@OUFA217 OUFA217 closed this Dec 20, 2024
@OUFA217 OUFA217 reopened this Dec 20, 2024
@OUFA217
Copy link
Contributor Author

OUFA217 commented Dec 22, 2024

Can you check again now?

@maheshj01
Copy link
Owner

Thank you will review it soon.

@maheshj01
Copy link
Owner

Rebase the master branch to fix this test failure.

@OUFA217
Copy link
Contributor Author

OUFA217 commented Dec 24, 2024

Can you check again?

@maheshj01
Copy link
Owner

Thank you for your contribution.

@maheshj01 maheshj01 merged commit d276ec4 into maheshj01:master Dec 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants