Testing of chromium distributed by grafana-image-renderer #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to do some basic test using chromium shipped by Grafana image renderer before using it. We were testing it using `--help` flag which does not exist on the application. If it works, it hangs which is not what we want. * This commit fixes this test by using a command that returns upon successful execution. We also use a timeout just in case to avoid the command hanging in there forever. * We also setup a special home directory for chromium and inject `XDG_CONFIG_HOME` and `XDG_CONFIG_HOME` env vars in chromium process. This avoids chromium attempting to create directories in read-only folders. Signed-off-by: Mahendra Paipuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do some basic test using chromium shipped by Grafana image renderer before using it. We were testing it using
--helpflag which does not exist on the application. If it works, it hangs which is not what we want.This commit fixes this test by using a command that returns upon successful execution. We also use a timeout just in case to avoid the command hanging in there forever.
We also setup a special home directory for chromium and inject
XDG_CONFIG_HOMEandXDG_CONFIG_HOMEenv vars in chromium process. This avoids chromium attempting to create directories in read-only folders.