Fix byte compilation warnings #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the byte compilation warnings: In mc--read-char: multiple-cursors-core.el:347:2: Warning: reference to free variable ‘multiple-cursors-mode’ In mc--read-quoted-char: multiple-cursors-core.el:348:2: Warning: reference to free variable ‘multiple-cursors-mode’ In mc--register-read-with-preview: multiple-cursors-core.el:349:2: Warning: reference to free variable ‘multiple-cursors-mode’ In mc--read-char-from-minibuffer: multiple-cursors-core.el:350:2: Warning: reference to free variable ‘multiple-cursors-mode’ In toplevel form: mc-mark-more.el:95:2: Warning: defvar `mc/enclose-search-term' docstring has wrong usage of unescaped single quotes (use \= or different quoting) In mc/mark-more-like-this-extended: mc-mark-more.el:501:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting) mc-mark-more.el:522:22: Warning: reference to free variable ‘mc/mark-more-like-this-extended-keymap’ In end of data: mc-mark-more.el:724:27: Warning: the function ‘sgml-skip-tag-forward’ is not known to be defined. mc-mark-more.el:673:8: Warning: the function ‘sgml-get-context’ is not known to be defined. In end of data: mc-hide-unmatched-lines-mode.el:110:1: Warning: the function ‘sgml-skip-tag-forward’ is not known to be defined. mc-hide-unmatched-lines-mode.el:110:1: Warning: the function ‘sgml-get-context’ is not known to be defined. In end of data: multiple-cursors-core.el:567:43: Warning: the function ‘sgml-skip-tag-forward’ is not known to be defined. multiple-cursors-core.el:535:25: Warning: the function ‘sgml-get-context’ is not known to be defined. In end of data: mc-cycle-cursors.el:124:1: Warning: the function ‘sgml-skip-tag-forward’ is not known to be defined. mc-cycle-cursors.el:124:1: Warning: the function ‘sgml-get-context’ is not known to be defined.
leotaku
reviewed
Feb 13, 2024
mc-mark-more.el
Outdated
| @@ -29,6 +29,9 @@ | |||
|
|
|||
| (require 'multiple-cursors-core) | |||
| (require 'thingatpt) | |||
| (require 'sgml-mode) | |||
|
|
|||
| (defvar mc/mark-more-like-this-extended-keymap (make-sparse-keymap)) | |||
There was a problem hiding this comment.
Not a huge fan of moving mc/mark-more-like-this-extended-keymap to the very top of the file. I would keep it grouped with the code that uses it.
Everything else looks very sensible though, thanks for contributing!
There was a problem hiding this comment.
I moved it to above the first function which references it 🙂
leotaku
approved these changes
Feb 23, 2024
|
This all seems good now, merged. Thank you for your contribution! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes the following byte compilation warnings I encountered on
29.1:Thanks!