-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use setcbreak instead of setraw, fixes #53 #54
Conversation
This breaks already functioning systems like cutie. |
@C0D3D3V You could build |
Yes, I was a bit hasty, sorry. Cutie still works. Only the keycode of the enter key is wrong as I pointed out in my PR. |
Wow... Cutie is very similar to inquirer, the reason that made me write readchar XD Do you think we should revert this? |
I think the majority of people don't want the enter key to do weird unexpected stuff and it should be easier to work around this being on than this being off |
Reverted as v3.0.4 |
I just tested We could also define the enter code to be both "\x0d" and "\x0a", then the problem would not exist. |
Noooo |
I cannot break previous way of work. |
Tested locally, works much better. setcbreak is definitely a better option than setraw.
See https://www.tutorialspoint.com/terminal-control-functions-in-python for more info.