Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: remove normalize_to_absolute_path #593

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Cube707
Copy link
Collaborator

@Cube707 Cube707 commented Jun 25, 2024

This removes the already non-working option normalize_to_absolute_path from the Path question type.

It was decided that inquirer will always return the exact user input and responsibilities like normalizing path's are up to the caller depending on his requirements

This should not affect anybody as the constructor still accepts all unknown keywords via **kwargs, meaning it gobble normalize_to_absolute_path if still present in existing code.

@Cube707 Cube707 requested a review from magmax as a code owner June 25, 2024 11:07
@Cube707 Cube707 added the breaking Breaking Changes label Jun 25, 2024
@Cube707 Cube707 merged commit 3dbd18e into main Jun 25, 2024
19 checks passed
@Cube707 Cube707 deleted the breaking/remove-path-normalistation branch June 25, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant