Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage documentation enhancements #467

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Usage documentation enhancements #467

merged 3 commits into from
Sep 18, 2023

Conversation

nwolff
Copy link
Contributor

@nwolff nwolff commented Sep 18, 2023

  • Replaced the term "sign" with "signature"
  • Fixed the validation example that would throw an exception due to a mismatch between str and int

@nwolff
Usage documentation enhancements
301a26b 
- Replaced the term "sign" with "signature"
- Fixed the validation example that would throw an exception
  due to a mismatch between str and int
Cube707
Cube707 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@Cube707 Cube707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@Cube707 Cube707 merged commit 2197493 into magmax:main Sep 18, 2023
8 of 9 checks passed
@nwolff nwolff deleted the usage-doc-enhancements branch September 18, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cube707 Cube707 Cube707 approved these changes

@magmax magmax Awaiting requested review from magmax magmax is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwolff @Cube707