My Additions (Path Question, Custom Questions, etc) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but with filesystem level tab complete; added ability to add new question types programmatically to a custom ConsoleRender
other question types; Added keyboard interrupt to Confirm
magmax
reviewed
Jun 30, 2018
|
@djf604 do you have any timeline to work on this as discussed earlier? I could incorporate the changes if you don't have time for it now :-) |
|
Since there is no update here and I think most of the issues it tackles is already integrated anyway, I am closing this PR. Feel free to reopen if there will be some update on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the functionality I've added here are useful and would be a benefit to all those using this wonderful library. Please refer to the commit messages for an overview of what I've added. I've also added documentation where appropriate.
Also note, the Path question does not support Windows, and I haven't even tried to do so. I left it as a TODO comment.