Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: implement DELETE #232

Merged
merged 1 commit into from
Aug 14, 2022
Merged

text: implement DELETE #232

merged 1 commit into from
Aug 14, 2022

Conversation

Cube707
Copy link
Collaborator

@Cube707 Cube707 commented Aug 13, 2022

DELETE removes the letter in front of the coursor

@Cube707 Cube707 added enhancement New feature or request python Pull requests that update Python code labels Aug 13, 2022
Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test to pass the pipeline =p

@Cube707
Copy link
Collaborator Author

Cube707 commented Aug 13, 2022

I completely forgot tests, lol

@Cube707 Cube707 marked this pull request as draft August 13, 2022 19:44
DELETE removes the letter in front of the coursor
@Cube707 Cube707 marked this pull request as ready for review August 14, 2022 11:12
@Cube707
Copy link
Collaborator Author

Cube707 commented Aug 14, 2022

I am still getting only 94% even with all my new codebranches coverd 🤷🏼‍♂️
I even test both when deleting in the middle of a word and the last letter, which is not the case on the existing tests.

image

I would say it's ready to merge.

@staticdev
Copy link
Collaborator

This is ok, we don't have to be super strict. 94% is good anyways ;)

@Cube707 Cube707 merged commit 2800517 into magmax:master Aug 14, 2022
@Cube707 Cube707 deleted the DELETE branch August 14, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants