bump readchar required version #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staticdev sorry I never worked with poetry and didn't know that. Should be done now, even if github isn't picking it up. |
|
I also just realsied that it might be a usefull step to limit the readchar version, as |
ensures better windows support and avoids broken v3.0.5
For now I think it is ok, since latest release is 3.1.0. If we know the code will break when 4.0.0 is released than we change something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readchars v3.0.5 broke linux support and will be avoided by this. Additionally the newer versions fix windows support for arrow-keys
fixes #198, closes #156, closes #155