Fix exclude-from-classpath containing wildcards #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
force-pushed
the
fix-exclude-from-classmap
branch
from
da222e3 to
8b6e849
Compare
MidnightDesign
pushed a commit
to MidnightDesign/ComposerRequireChecker
that referenced
this pull request
Sep 17, 2020
Fixed travis lint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and thanks for this great tool!
With the latest version (which adds exclude-from-classpath support), I observed an common errors like this:
This is because
exclude-from-classpathcan contain*and**wildcards. For example in Symfony: https://github.com/symfony/symfony/blob/master/composer.json#L125 .These
*and**sequences obviously breaks the regexp pattern used in LocateAllFilesByExtension.php and causes the mentioned error.This PR adds regexp escaping and also supports of the actual wildcards behavior, as per Composer source code: https://github.com/composer/composer/blob/be040f8e3111b38c1e49ae5cd6b929dbf5c39045/src/Composer/Autoload/AutoloadGenerator.php#L848-L854