Replace VFS Stream with spatie temp directory #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
fredden
force-pushed
the
tests/vfs-tmp
branch
5 times, most recently
from
a256e99 to
90eb05f
Compare
|
@fredden btw, observing your regular pushes and understanding your frustration: filesystems are hard. Also, I wish we never supported |
|
@Ocramius I think this pull request is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an incompatibility with the test-suite, where real files weren't being used to run the tests. This works fine most of the time, but this is not compatible with the changes in #511. I've put these changes in a separate pull request so they can be evaluated separately from #511. There should be no changes to functionality nor test coverage with this pull request.