False positives on some bundle and classes #55
Comments
|
Another false positive not related to bundles: class: |
soullivaneuh
changed the title
|
I updated the issue body. Except |
|
@maglnet do we have something to collect all defined symbols and the defining files? Would be interesting to have some debug output that dumps all files associated with the originating file. |
|
@soullivaneuh it seems that all the |
You are right, only some are reported.
It looks like not. But I found the I check that on some bundle of this list, and they all use this keyword. I think it's a clue. 👍 |
|
I don't think |
|
|
|
@Ocramius Well, is that really hard to manage Maybe this tool should also trow a warning about that? Going back to the issue. Some other bundle does not work simply because composer.json is not present. For example: https://github.com/dmaicher/doctrine-test-bundle/blob/ccdea2ce9fec5048385d1b9b5bc7c4c3f32ab48f/.gitattributes |
It's needed for some CI tools. See also: maglnet/ComposerRequireChecker#55
|
@soullivaneuh most of these issues would be fixed by switching to BetterReflection, I reckon. It's just not gonna be nice for performance, but it would be much, much more reliable :-) |
Sadly currently not, but this should be done soon as it would make debugging issues like this a lot easier and also gives a user hints where dependencies are found without the need to do a fulltext search within the code. |
It's needed for some CI tools. See also: maglnet/ComposerRequireChecker#55
It's a dev tool. IMHO, we can drop a bit of performance to make it more reliable. 😉 |
|
Another case: For this one, I don't know why composer-require-checker is yelling. The EDIT: Same thing for:
|
|
Concerning "autoload": {
"files": ["lib/swift_required.php"]
}, |
|
Concerning define('KERNEL_ROOT_DIR', __DIR__)And this php file is auto-loaded by composer, so it should not be an issue. |
|
Ok, I understand the problem with The second problem with the constant could be, that the autoloaded file requires another file and we currently do not follow |
Please see swiftmailer/swiftmailer#971 (comment).
The define function is on the "autoload": {
"psr-4": { "": "src/" },
"files": [
"app/env.php",
"app/AppKernel.php"
]
}, |
|
Another false positive since I split the Symfony fullstack requirement from my project: But they are correctly required and installed under a dev env: "require-dev": {
"symfony/debug-bundle": "^4.0",
"symfony/var-dumper": "^4.0",
"symfony/web-profiler-bundle": "^4.0",
"symfony/web-server-bundle": "^4.0"
}, |
Are they used in |
|
@Ocramius It's quite more complicated, it's only bundle instantiation on |
|
Btw, yes, I fully understand where this comes from: I'm just saying that the exit code with this particular tool will always be |
|
I understand your point of view but I still think files like I won't require packages on production if I don't need them. Plus for that case, it will an issue for a lot of people following the Symfony standard. Adding a simple option listing the specific files where the tool should not care if they are require on dev env or not and let the user take the risk (or not) still worth it IMHO! :-) Shall I open a separate issue for that? |
|
Well, the |
I said it many, many, many many times: I don't care what
My simplistic suggestion (because every tool is opinionated, and these will always pop up a lot) is to suggest a feature in which we can map |
Yeah, your choice, I'm not trying to convince you. But yes, an option to permit both would solve everything! 👍 I'm on the issue. |
|
The problem regarding the constant from #55 (comment) should be fixed with 0.2.1 |
might be a workaround for some of maglnet#55's issues
might be a workaround for some of maglnet#55's issues
|
Hello, I had the same issue, with composer.json: My command and his output: My usage: Best regards, |
|
Hi guys, I think that a lot of these are false positives. For sure |
|
I don't see |
|
It's a dependency of |
@mmenozzi the idea of this tool ;) -> https://github.com/maglnet/ComposerRequireChecker#whats-it-about |
I swear that I've read it before submitting this comment. Now I just read it again twice and I understood. Sorry guys. |
|
Regarding |
|
|
|
Unfortunately, the way suggested by Symfony is one big array with all bundle classes as keys and sub-arrays for each one choosing the environment where it should be used. |
|
Yes, and you can split the development config into a separate file to be put somewhere outside your sources. |
|
i might have found a false-positive for |
|
One more false-positive: +-----------------+--------------------+
| unknown symbol | guessed dependency |
+-----------------+--------------------+
| IMAP\Connection | |
+-----------------+--------------------+
"require": {
"php": "^7.2 || ^8.0",
"ext-fileinfo": "*",
"ext-iconv": "*",
"ext-imap": "*",
"ext-mbstring": "*"
},See https://github.com/barbushin/php-imap/blob/master/composer.json Would be also helpful, if I would just be able to "ignore" specific unknown symbols using the config file. |
|
Hi,
I'm not sure if it's a false positive.
If you're running the check with PHP versions < 8.1 the class is not available (seems like it was introduced with 8.1) and so it's a unknown symbol for the lower versions.
Ignoring symbols is already possible. Please have a look at the `symbol-whitelist` within the example configuration: https://github.com/maglnet/ComposerRequireChecker/blob/3.7.x/data/config.dist.json
|
|
Looks like the referenced project has never released a version that is compatible with PHP 8.1. I cannot identify what exactly is going on, but that link above currently reads which is true for all versions 4.2.x, any earlier 4.x is allowing php ^7.2, and version 3.x states php >=5.5 or >=5.6. Looking at their bugtracker, apparently being compatible with PHP 8.1 is an open issue right now. |
This is still an issue.. This checker will only recognize it when spelled with a capital |
|
Sounds like a separate issue: perhaps send a patch with a test around case sensitivity? |
Command result (extract):
But the corresponding bundles are required on the root composer.json file:
{ "php": "^7.1", "ext-PDO": "^7.1", "ext-dom": "20031129", "ext-filter": "^7.1", "ext-hash": "^1.0", "ext-intl": "^1.0.2", "ext-json": "^1.5", "ext-openssl": "^7.1", "a2lix/translation-form-bundle": "^2.1", "algatux/influxdb-bundle": "^2.1", "behat/transliterator": "^1.2", "browscap/browscap-bundle": "^1.0", "browscap/browscap-php": "^2.1", "cebe/markdown": "^1.1", "digitick/sepa-xml": "^1.0", "doctrine/annotations": "^1.6", "doctrine/cache": "^1.7", "doctrine/collections": "^1.5", "doctrine/common": "^2.8", "doctrine/dbal": "^2.6", "doctrine/doctrine-bundle": "^1.6", "doctrine/doctrine-cache-bundle": "^1.3", "doctrine/doctrine-migrations-bundle": "^1.0", "doctrine/inflector": "^1.3", "doctrine/orm": "^2.6", "dompdf/dompdf": "^0.8", "egulias/email-validator": "^2.1", "eightpoints/guzzle-bundle": "^6.1", "emojione/emojione": "^3.1.2", "fabpot/goutte": "^3.0", "friendsofsymfony/jsrouting-bundle": "^1.5", "friendsofsymfony/oauth-server-bundle": "^1.4", "friendsofsymfony/oauth2-php": "^1.2", "friendsofsymfony/rest-bundle": "^2.0", "friendsofsymfony/user-bundle": "^2.0", "fzaninotto/faker": "^1.7", "giggsey/libphonenumber-for-php": "^8.9", "greg0ire/enum": "^3.1", "gregwar/image-bundle": "^2.1", "guzzlehttp/guzzle": "^6.0", "hackzilla/password-generator": "^1.4", "hackzilla/password-generator-bundle": "^2.0", "hautelook/alice-bundle": "^1.0", "incenteev/composer-parameter-handler": "^2.0", "influxdb/influxdb-php": "^1.14", "inlinestyle/inlinestyle": "^1.2", "internations/solr-utils": "^0.8", "jms/serializer": "^1.11", "jms/serializer-bundle": "^2.1", "jms/translation-bundle": "^1.4", "knplabs/doctrine-behaviors": "^1.4", "knplabs/knp-markdown-bundle": "^1.3", "knplabs/knp-menu": "^2.3", "knplabs/knp-menu-bundle": "^2.0", "knplabs/knp-paginator-bundle": "^2.4.3", "kriswallsmith/spork": "^0.3", "lexik/jwt-authentication-bundle": "^2.4", "lstrojny/fxmlrpc": "^0.14.0", "misd/phone-number-bundle": "^1.2", "monolog/monolog": "^1.23", "mtdowling/cron-expression": "^1.1", "nelmio/alice": "^2.0", "nelmio/api-doc-bundle": "dev-nexy as 2.10", "nexylan/cloudflare": "dev-master", "nexylan/cloudflare-host-gw": "^0.1", "nexylan/gandi-sdk": "^0.3", "nexylan/graylog-sdk": "^0.1", "nexylan/nexycrypt": "^0.2", "nexylan/paybox-direct": "^0.3.4", "nexylan/slack": "^1.7", "nexylan/slack-bundle": "^1.1", "ornicar/gravatar-bundle": "^1.2", "ovh/ovh": "^2.0", "patchwork/utf8": "^1.3", "php-http/guzzle6-adapter": "^1.1", "php-http/httplug-bundle": "^1.7", "predis/predis": "^1.0", "psr/http-message": "^1.0", "psr/log": "^1.0", "rollerworks/password-strength-bundle": "^2.0", "rollerworks/password-strength-validator": "^1.0", "sensio/distribution-bundle": "^5.0", "sensio/framework-extra-bundle": "^5.0.1", "simplethings/entity-audit-bundle": "^1.0.1", "sllh/iso-codes-validator": "^3.1", "snc/redis-bundle": "^2.0,>2.0.2", "sonata-project/admin-bundle": "^3.3", "sonata-project/block-bundle": "^3.12", "sonata-project/core-bundle": "^3.9", "sonata-project/doctrine-extensions": "^1.0", "sonata-project/doctrine-orm-admin-bundle": "^3.0.3", "sonata-project/intl-bundle": "^2.2", "stof/doctrine-extensions-bundle": "^1.1", "swiftmailer/swiftmailer": "^6.0", "symfony/dotenv": "^4.0", "symfony/monolog-bundle": "^3.0", "symfony/phpunit-bridge": "^3.1", "symfony/swiftmailer-bundle": "^3.0", "symfony/symfony": "^3.4", "tilleuls/ovh-bundle": "^1.0", "twig/extensions": "^1.0", "twig/twig": "^2.4", "webmozart/assert": "^1.2" }, "require-dev": { "behat/mink-browserkit-driver": "^1.3", "behat/mink-extension": "^2.0", "behat/mink-selenium2-driver": "^1.2", "behat/symfony2-extension": "^2.0", "dama/doctrine-test-bundle": "^4.0", "doctrine/doctrine-fixtures-bundle": "^2.4", "jolicode/gif-exception-bundle": "^1.4", "knplabs/friendly-contexts": "^0.8", "liip/functional-test-bundle": "^1.9", "lookyman/phpstan-symfony": "^0.4.1", "phpdocumentor/reflection-docblock": "^3.2.3", "phpstan/phpstan-doctrine": "^0.9.1", "phpstan/phpstan-phpunit": "^0.9.3", "phpstan/phpstan-shim": "^0.9.1", "phpstan/phpstan-strict-rules": "^0.9.0", "phpunit/phpunit": "^6.4", "sensio/generator-bundle": "^3.1", "sonata-project/easy-extends-bundle": "^2.5", "symfony/web-server-bundle": "^3.3" }The text was updated successfully, but these errors were encountered: