Expose Isocut Threshold #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'd have to confirm with @magland to be certain but it looks okay-ish for me. |
|
go ahead, expose it. against the philosophy. but i am guessing you will
find clustering to be insensitive to changes in tgis threshold, which is
good IMO.
…On Thursday, April 13, 2017, Witold Wysota ***@***.***> wrote:
You'd have to confirm with @magland <https://github.com/magland> to be
certain but it looks okay-ish for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADgkQMA-1M-qUsueTqWRsePUtvHZ7hUiks5rvjnbgaJpZM4M80Eu>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wysota I suspect that you guys don't want to expose this option to the user but if I wanted to play around with it is there something else I need to change in the p_sort_clips.cpp?