Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): add new ripple button component #381

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

Sidd5arth
Copy link
Contributor

Hello there,

I’ve developed a new button component that includes a ripple animation. I’ve tested it across multiple scenarios and devices to ensure compatibility with the existing features. I have updated the documentation as well.

Please review the changes and let me know your thoughts or if any adjustments are needed.

Thank you!

button-ripple.mp4

Copy link

vercel bot commented Oct 18, 2024

@Sidd5arth is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Sidd5arth
Copy link
Contributor Author

@dillionverma can you take a look

@dillionverma
Copy link
Collaborator

👀

@itsarghyadas
Copy link
Collaborator

Nice job adding this button! I’ve added support for multiple onClick handlers and forwardRef, as the button should have those. Thanks for the contribution!

@itsarghyadas itsarghyadas merged commit 5f0347a into magicuidesign:main Nov 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants